Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EL-1913 update file size in links #1667

Merged
merged 5 commits into from
Nov 26, 2024
Merged

EL-1913 update file size in links #1667

merged 5 commits into from
Nov 26, 2024

Conversation

willc-work
Copy link
Contributor

Jira ticket

What changed and why

updated file size for guidance docs

Guidance to review

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing
  • Branch is generally up to date with main Github - definitely no conflicts
  • No unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • PR description says what changed and why, with a link to the JIRA story.
  • Diff has been checked for unexpected changes being included.
  • Commit messages say why the change was made.

@willc-work willc-work marked this pull request as ready for review November 20, 2024 16:11
@willc-work willc-work requested a review from a team as a code owner November 20, 2024 16:11
@willc-work willc-work changed the base branch from main to el-1893-mtr-broken-tests-feature-flag November 21, 2024 10:20
Base automatically changed from el-1893-mtr-broken-tests-feature-flag to main November 21, 2024 10:55
@willc-work willc-work force-pushed the EL-1913-filesize branch 2 times, most recently from 61a37d2 to 4458cbe Compare November 21, 2024 11:05
MazOneTwoOne
MazOneTwoOne reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@MazOneTwoOne MazOneTwoOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@willc-work I think there are some "1.5MB" instead of "1.51MB"

@willc-work
Copy link
Contributor Author

@MazOneTwoOne ready for review again, thanks

@MazOneTwoOne MazOneTwoOne added Approved UAT Keep PR open to keep ephemeral UAT URL alive and removed Ready For Review labels Nov 21, 2024
MazOneTwoOne and others added 4 commits November 26, 2024 09:30
@MazOneTwoOne @willc-work
WIP:
23a981e 
- fix broken tests
- update `external_link_service.rb` and related spec
@MazOneTwoOne @willc-work
- update helpers
9e954df 
- remove 'mtr' translations
- update views
@willc-work
update file size
5a7ac38 
fix tests after rebase
@willc-work
correct filesize
fb07f73
@willc-work willc-work merged commit 3d2d59f into main Nov 26, 2024
12 checks passed
@willc-work willc-work deleted the EL-1913-filesize branch November 26, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MazOneTwoOne MazOneTwoOne MazOneTwoOne approved these changes

Assignees
No one assigned
Labels
Approved UAT Keep PR open to keep ephemeral UAT URL alive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willc-work @MazOneTwoOne