Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EL-1878: govuk-frontend 5.7.1 bump #1669

Merged
merged 7 commits into from
Nov 26, 2024
Merged

EL-1878: govuk-frontend 5.7.1 bump #1669

merged 7 commits into from
Nov 26, 2024

Conversation

MazOneTwoOne
Copy link
Contributor

@MazOneTwoOne MazOneTwoOne commented Nov 21, 2024 •
edited
Loading

Jira ticket

What changed and why

  • update CCQ govuk-frontend to 5.7.1

Guidance to review

  • n/a

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing
  • Branch is generally up to date with main Github - definitely no conflicts
  • No unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • PR description says what changed and why, with a link to the JIRA story.
  • Diff has been checked for unexpected changes being included.
  • Commit messages say why the change was made.

@MazOneTwoOne MazOneTwoOne added this to the use n milestone Nov 21, 2024
@MazOneTwoOne MazOneTwoOne marked this pull request as ready for review November 21, 2024 17:22
@MazOneTwoOne MazOneTwoOne requested a review from a team as a code owner November 21, 2024 17:22
@MazOneTwoOne
- update the numbering on the data-add-another-dynamic-elements so …
ec3693b 
…that `aria-controls` increments and decrements as expected.
psweeting1
psweeting1 approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@psweeting1 psweeting1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MazOneTwoOne MazOneTwoOne added Approved UAT Keep PR open to keep ephemeral UAT URL alive and removed Ready For Review labels Nov 25, 2024
@MazOneTwoOne MazOneTwoOne merged commit 8773634 into main Nov 26, 2024
12 checks passed
@MazOneTwoOne MazOneTwoOne deleted the el-1878-govuk-5-7-1-bump branch November 26, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psweeting1 psweeting1 psweeting1 approved these changes

Assignees
No one assigned
Labels
Approved UAT Keep PR open to keep ephemeral UAT URL alive
Projects
None yet
Milestone
use n
Development

Successfully merging this pull request may close these issues.
2 participants
@MazOneTwoOne @psweeting1