Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component): add link button component #429

Closed
wants to merge 2 commits into from
Closed

Conversation

alex-hedley
Copy link

fix #428

Issue or RFC endorsed by the maintainers

N/A

Description of the change

Added link-button.

Alternative designs

N/A

Possible drawbacks

N/A

Verification process

Release notes

  • Added mojLinkButton.

@alex-hedley alex-hedley added the enhancement New feature or request label Dec 28, 2022
@alex-hedley alex-hedley requested a review from a team as a code owner December 28, 2022 13:43
@alex-hedley
Copy link
Author

@gregtyler
Copy link
Contributor

Hi Alex! I think this pattern would be more helpful in a library for Nunjucks applications since it mostly revolves around a reusable Nunjucks snippet. And whilst the general HTML could be used by non-Nunjucks services, I don't think it's something we should suggest we have standards around but should leave each service to implement as best suits them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Link Button
2 participants