Fix msvc miniupnpc shared library build #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #270 Both libminiupnpc-static and libminiupnpc-shared targets were generated miniupnpc.lib files. Now libminiupnpc-static generates libminiupnpc.lib whereas libminiupnpc-shared generates miniupnpc.lib and miniupnpc.dll
This was referenced Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #270
Both libminiupnpc-static and libminiupnpc-shared targets generated
miniupnpc.libfile. As a result, the lib file for a shared library was overwritten with lib file for a static library.Now libminiupnpc-static target creates
libminiupnpc.libfile whereas libminiupnpc-shared target createsminiupnpc.libandminiupnpc.dllfiles on Windows.