Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSP: Add support for Go to Definition #575

Merged
merged 17 commits into from
Apr 25, 2023
Merged

LSP: Add support for Go to Definition #575

Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
a2bcfc3
Add basic support for "Goto Definition Request" in the language server
jansul Apr 2, 2023
a3507f1
Return `null` as result when definition cannot be found
jansul Apr 2, 2023
31867f3
Move definition logic to separate files
jansul Apr 8, 2023
399859d
Add tests for language server additions
jansul Apr 10, 2023
846f55e
Add helper methods for finding nodes within cursor stack
jansul Apr 15, 2023
5224ce7
Modify LSP server methods to closer match the specification
jansul Apr 15, 2023
e9e0054
Move selection into main Definition class
jansul Apr 15, 2023
194eaa7
Fix ameba issues
jansul Apr 15, 2023
7dc6d08
Update definition tests to be a similar format to type_checking specs
jansul Apr 19, 2023
6c54157
Remove macros and prevent duplicating stack
jansul Apr 19, 2023
4603716
Update LS definition to support Location as well as LocationLink
jansul Apr 19, 2023
023e2f8
Add spec's for `Location` definition responses
jansul Apr 21, 2023
cdc42f9
Fix minor ameba issue
jansul Apr 21, 2023
8d62186
Fix offset when finding definition for components with comments
jansul Apr 22, 2023
4e5e6f1
Fix LS returning definition responses for core components
jansul Apr 22, 2023
1ffe9ba
Add new lines to definition specs and move StackReader to its own file
jansul Apr 22, 2023
33cf531
Apply suggestions from code review
gdotdesign Apr 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions spec/language_server/definition/core_component
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
component Test {
fun render : Html {
<Unless condition={true}>
<div/>
</Unless>
}
}
------------------------------------------------------------------file test.mint
{
"jsonrpc": "2.0",
"id": 0,
"params": {
"textDocument": {
"uri": "file://#{root_path}/test.mint"
},
"position": {
"line": 2,
"character": 7
}
},
"method": "textDocument/definition"
}
-------------------------------------------------------------------------request
{
"jsonrpc": "2.0",
"id": 1,
"params": {
"textDocument": {
"uri": "file://#{root_path}/test.mint"
},
"position": {
"line": 2,
"character": 13
}
},
"method": "textDocument/definition"
}
-------------------------------------------------------------------------request
{
"jsonrpc": "2.0",
"result": null,
"id": 0
}
------------------------------------------------------------------------response
{
"jsonrpc": "2.0",
"result": null,
"id": 1
}
------------------------------------------------------------------------response
jansul marked this conversation as resolved.
Show resolved Hide resolved
61 changes: 61 additions & 0 deletions spec/language_server/definition/location/html_attribute
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
component Button {
property size : String = "small"

fun render : Html {
<button/>
}
}
----------------------------------------------------------------file button.mint
component Test {
fun render : Html {
<Button size="large"/>
}
}
------------------------------------------------------------------file test.mint
{
"id": 0,
"method": "initialize",
"params": {
"capabilities": {
"textDocument": {
"definition": {
"linkSupport": false
}
}
}
}
}
-------------------------------------------------------------------------request
{
"jsonrpc": "2.0",
"id": 1,
"params": {
"textDocument": {
"uri": "file://#{root_path}/test.mint"
},
"position": {
"line": 2,
"character": 13
}
},
"method": "textDocument/definition"
}
-------------------------------------------------------------------------request
{
"jsonrpc": "2.0",
"result": {
"range": {
"start": {
"line": 1,
"character": 11
},
"end": {
"line": 1,
"character": 15
}
},
"uri": "file://#{root_path}/button.mint"
},
"id": 1
}
------------------------------------------------------------------------response
60 changes: 60 additions & 0 deletions spec/language_server/definition/location/html_component
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
/* Comment for Button component. */
component Button {
fun render : Html {
<button />
}
}
----------------------------------------------------------------file button.mint
component Test {
fun render : Html {
<Button />
}
}
------------------------------------------------------------------file test.mint
{
"id": 0,
"method": "initialize",
"params": {
"capabilities": {
"textDocument": {
"definition": {
"linkSupport": false
}
}
}
}
}
-------------------------------------------------------------------------request
{
"jsonrpc": "2.0",
"id": 1,
"params": {
"textDocument": {
"uri": "file://#{root_path}/test.mint"
},
"position": {
"line": 2,
"character": 7
}
},
"method": "textDocument/definition"
}
-------------------------------------------------------------------------request
{
"jsonrpc": "2.0",
"result": {
"range": {
"start": {
"line": 1,
"character": 10
},
"end": {
"line": 1,
"character": 16
}
},
"uri": "file://#{root_path}/button.mint"
},
"id": 1
}
------------------------------------------------------------------------response
57 changes: 57 additions & 0 deletions spec/language_server/definition/location/html_style
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
component Test {
style test {

}

fun render : Html {
<div::test/>
}
}
------------------------------------------------------------------file test.mint
{
"id": 0,
"method": "initialize",
"params": {
"capabilities": {
"textDocument": {
"definition": {
"linkSupport": false
}
}
}
}
}
-------------------------------------------------------------------------request
{
"jsonrpc": "2.0",
"id": 1,
"params": {
"textDocument": {
"uri": "file://#{root_path}/test.mint"
},
"position": {
"line": 6,
"character": 12
}
},
"method": "textDocument/definition"
}
-------------------------------------------------------------------------request
{
"jsonrpc": "2.0",
"result": {
"range": {
"start": {
"line": 1,
"character": 8
},
"end": {
"line": 1,
"character": 12
}
},
"uri": "file://#{root_path}/test.mint"
},
"id": 1
}
------------------------------------------------------------------------response
81 changes: 81 additions & 0 deletions spec/language_server/definition/location_link/html_attribute
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
component Button {
property size : String = "small"

fun render : Html {
<button/>
}
}
----------------------------------------------------------------file button.mint
component Test {
fun render : Html {
<Button size="large"/>
}
}
------------------------------------------------------------------file test.mint
{
"id": 0,
"method": "initialize",
"params": {
"capabilities": {
"textDocument": {
"definition": {
"linkSupport": true
}
}
}
}
}
-------------------------------------------------------------------------request
{
"jsonrpc": "2.0",
"id": 1,
"params": {
"textDocument": {
"uri": "file://#{root_path}/test.mint"
},
"position": {
"line": 2,
"character": 13
}
},
"method": "textDocument/definition"
}
-------------------------------------------------------------------------request
{
"jsonrpc": "2.0",
"result": {
"originSelectionRange": {
"start": {
"line": 2,
"character": 12
},
"end": {
"line": 2,
"character": 16
}
},
"targetUri": "file://#{root_path}/button.mint",
"targetRange": {
"start": {
"line": 1,
"character": 2
},
"end": {
"line": 1,
"character": 34
}
},
"targetSelectionRange": {
"start": {
"line": 1,
"character": 11
},
"end": {
"line": 1,
"character": 15
}
}
},
"id": 1
}
------------------------------------------------------------------------response
Loading