Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve feerate points RPC node call #1409

Open
OBorce opened this issue Dec 18, 2023 · 0 comments
Open

Improve feerate points RPC node call #1409

OBorce opened this issue Dec 18, 2023 · 0 comments

Comments

@OBorce
Copy link
Contributor

OBorce commented Dec 18, 2023

I am not convinced the number of points is a good way to parameterise this. Tn that case, the resolution depends on the number of transactions in the mempool. E.g. if the user asks for 10 points, in a mempool with a 200B transaction, you get a sample every 20B (needless accuracy) whereas in a mempool with 100MB worth of transactions, you get a sample every 10MB (way too inaccurate).

Maybe a more interesting would be to specify the sampling interval and a max limit. E.g. sample every 200kB and max 50 samples to cover top 10 blocks. Probably more intuitive that way.

As a bit more out there idea (not for this PR), maybe the sampling should not be uniform but logarithmic. I can imagine the feerate distribution close to the top of the mempool is more interesting than 10s or 100s of MB down the line.

This will not be a breaking change it will only change the number of points being retuned to better capture the mempool's feerate curve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant