Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Third unit test in test_gp_from_aimd takes forever and sometimes fails #43

Closed
jonpvandermause opened this issue Sep 13, 2019 · 5 comments

Comments

@jonpvandermause
Copy link
Collaborator

jonpvandermause commented Sep 13, 2019

@stevetorr could you take a look?

Here's a screenshot of the error:

image

@stevetorr
Copy link
Contributor

Sounds like there's an issue with the training. I'm looking into this. FWIW it always works on my local computer (and runs in about 10 seconds). I can push a quick fix that makes it run faster and should avert this error and look into it more soon.

@jonpvandermause
Copy link
Collaborator Author

It's actually failing every time on my machine now. Have you pulled all the updates?

@stevetorr
Copy link
Contributor

This commit should speed it up:
2622d2c

While it makes the test slightly 'weaker' by no longer training the GP, other unit tests cover the act of calling and training a GP. I will open an issue to make this unit test better.

@stevetorr
Copy link
Contributor

Also FWIW, it wasn't just you: I tried the offending unit test on Odyssey and it did indeed hang there. Things should all be up to date. We can take the difference between the above new commit and the current development branch to see what's wrong.

@stevetorr
Copy link
Contributor

Opened a PR, thanks for bringing this to my attention. Sorry I didn't catch it sooner!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants