Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: should enforce (internally) to -t 0 (i.e., wait till the device replies) on state.* functions? #182

Open
mirceaulinic opened this issue Oct 23, 2020 · 1 comment
Open

Question: should enforce (internally) to -t 0 (i.e., wait till the device replies) on state.* functions? #182

mirceaulinic opened this issue Oct 23, 2020 · 1 comment
Assignees
@mirceaulinic
Labels
awaiting feedback help wanted Extra attention is needed question Further information is requested
Milestone
HOLD

Comments

@mirceaulinic
Copy link
Owner

state.* typically take a long time to execute, and the run time is probably not often known or immediately obvious. In that case, the command is executed with -t to ensure salt-sproxy waits for the reply sufficiently. Now, -t is either 0 or a very large value. So I'm wondering if it wouldn't make sense to just default it to 0 natively on state.* function, out of the box?
@mirceaulinic mirceaulinic added the question Further information is requested label Oct 23, 2020
@mirceaulinic mirceaulinic added this to the HOLD milestone Oct 23, 2020
@mirceaulinic mirceaulinic self-assigned this Oct 23, 2020
@mirceaulinic mirceaulinic mentioned this issue Oct 23, 2020
Closed
@mirceaulinic
Copy link
Owner Author


@mirceaulinic mirceaulinic added awaiting feedback help wanted Extra attention is needed labels Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mirceaulinic mirceaulinic

Labels
awaiting feedback help wanted Extra attention is needed question Further information is requested
Projects
None yet
Milestone
HOLD
Development

No branches or pull requests
1 participant
@mirceaulinic