Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating to scottcs's hammerspoon config #1

Closed
rxng opened this issue Dec 11, 2016 · 6 comments
Closed

Integrating to scottcs's hammerspoon config #1

rxng opened this issue Dec 11, 2016 · 6 comments

Comments

@rxng
Copy link

rxng commented Dec 11, 2016

Hi, I am unable to get the window to maximise using hyper shift + up + down - it becomes a quarter window instead?

@miromannino
Copy link
Owner

miromannino commented Dec 11, 2016

Hello, there are no commands with shift. To maximize there is this simple concept that up+down (or right+left) expand the window vertically (or horizontally).

So let's say you have the window in the right-bottom corner, up+down will expand the window to be half of the screen (right side, since it was on the right-bottom corner). Then only pressing left+right, the window is expanded to be full screen, since the window width is expanded horizontally.

Seems confusing to explain in words but it's really intuitive if you think about that.

But If you just want to directly expand the window fullscreen in one shot, I suggest you the hyper+F

Hope it helps

@rxng
Copy link
Author

rxng commented Dec 12, 2016

Thanks @miromannino

I have got it working, and it's something I have been looking for all my life! It is really intuitive and ingenious once you see the magic it can do.

Currently trying to integrate it into a module, but realise that I can't do it because the key release is not setting the false correctly I think? Would you be able to help out? here are the files attached. (bindings are in binding.lua line 92 to 99)
window.zip

It would really be a lifesaver and be greatly appreciated :)

@miromannino
Copy link
Owner

A module? Where will it go?

What about missing copyrights on position.lua? I added in position.lua, so it's easier to remember to include them. It's just the copyright line at the end.

@rxng
Copy link
Author

rxng commented Dec 12, 2016

I'm not sure where it goes, as still figuring this out at the moment, I am using https://github.com/scottcs/dot_hammerspoon at the moment and it makes use of modules. Am having trouble integrating your config into that one...

Happy to put any and all full copyright info (I'm not distributing this, just using it - maybe with friends), so if you do find a way to do that please let me know ? Thank you

@miromannino miromannino changed the title everything works except the maximise function Integrating to scottcs's hammerspoon config Dec 12, 2016
@miromannino
Copy link
Owner

Ok I will review this, but I don't promise anything for sure, I am really busy. Tell me if you are able to integrate it. I am sure it's something simple.

@miromannino
Copy link
Owner

Now can be used as a spoon, which is much more standard.

miromannino pushed a commit that referenced this issue Feb 6, 2022
Add middle functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants