Boolean conditions not fully optimized

[ThomasR]

Consider this simple code

if (a == 1 || b == 2) {
  foo();
}

It gets compressed to

(1==a||2==b)&&foo();

This is not optimal. 1!=a&&2!=b||foo(); is shorter.

---

Strange enough, I found that when compressing the equivalent code

if (!(a == 1 || b==2 )) {} else {
  foo();
}

the result is indeed

1!=a&&2!=b||foo();

as requested.

[kzc]

I have a fix for this. Will create a PR tomorrow.

if (a == 1 || b == 2) foo();

Uglify is aware of the negative condition optimization. This issue is occurring because the length of the original condition 1==a||2==b and the negated condition 1!=a&&2!=b are the same so uglify bases its optimization on the original. But the code doesn't take into account that || has lower precedence than && in the expression (1==a||2==b)&&foo();, and as such the solution with the original condition is 2 (paren) characters longer than the solution with the negated condition 1!=a&&2!=b||foo();

[kzc]

Fix in PR #981

[ThomasR]

Awesome, thank you!