Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag-name does not support Changesets format #37

Closed
john-u opened this issue Jun 22, 2022 · 4 comments
Closed

tag-name does not support Changesets format #37

john-u opened this issue Jun 22, 2022 · 4 comments

Comments

@john-u
Copy link

john-u commented Jun 22, 2022

Thanks for the awesome action! We are trying to use this on our monorepo that is versioned and tagged using Changesets which uses the tag format packageName@version. In our case, the tag of the package we want to release is @smartthings/cli@1.0.0-beta.x. The action is failing with the following.

Run mislav/bump-homebrew-formula-action@v2
  with:
    tag-name: @smartthings/cli@1.0.0-beta.9
    download-url: https://github.com/john-u/smartthings-cli/releases/download/@smartthings/cli@1.0.0-beta.9/smartthings-macos.tar.gz
    homebrew-tap: https://github.com/john-u/homebrew-smartthings
    commit-message: {{formulaName}} {{version}}
  
  Created by https://github.com/mislav/bump-homebrew-formula-action
  
  env:
    COMMITTER_TOKEN: ***
request
GET /repos/john-u/smartthings-cli/releases/tags/%40smartthings - 404 in 247ms
Error: HttpError: Not Found

I've tried numerous input but it looks like it is cutting off after the / in the scoped package name (and url encoding it, though not sure that would matter). The reason we can't just let the name default to the currently pushed tag is that changesets will tag each release with multiple names for each released package, so the top ref may not be the one we want.

@mislav mislav closed this as completed in 5983bb6 Jun 23, 2022
@mislav
Copy link
Owner

mislav commented Jun 23, 2022

Thanks for reporting! Please try out the newest @v2 release

@john-u
Copy link
Author

john-u commented Jun 23, 2022

It made it a little farther, but still fails calling a URL I don't recognize.

Run mislav/bump-homebrew-formula-action@v2
request
GET /repos/john-u/smartthings-cli/releases/tags/%40smartthings%2Fcli%401.0.0-beta.9 - 200 in 118ms
request
GET /repos/john-u/smartthings-cli/releases/assets/69287324 - 302 in 118ms
request
GET /repos/https%3A/ - 404 in 59ms
Error: HttpError: Not Found

Here is the run https://github.com/john-u/smartthings-cli/runs/7027429950

@mislav
Copy link
Owner

mislav commented Jun 23, 2022

This shouldn't be a full URL:

homebrew-tap: https://github.com/john-u/homebrew-smartthings

Try just the owner/repo pair

@john-u
Copy link
Author

john-u commented Jun 23, 2022

Ah, I missed that. It is working as expected now. Thank you for the quick turnaround on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants