Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signup email not translated #11060

Open
tassoman opened this issue Jun 30, 2023 · 3 comments
Open

Signup email not translated #11060

tassoman opened this issue Jun 30, 2023 · 3 comments
Labels
✨Feature This adds/improves/enhances a feature 🔥high priority i18n Internationalization (i18n) related issue/PR packages/backend Server side specific issue/PR

Comments

@tassoman
Copy link
Contributor

💡 Summary

I just tested signup process on my Italian locale instance, but signup mail was sent in English. There are no strings on Crowdin, to translate.

🥰 Expected Behavior

I expect to be able to translate all mail notifications.

🤬 Actual Behavior

Mail notifications are sent in english.

📝 Steps to Reproduce

  1. setup an instance
  2. set italian locale language
  3. setup SMTP mail
  4. register a new profile

📌 Environment

💻 Frontend

  • Model and OS of the device(s): Linux Debian
  • Browser: Firefox 114
  • Server URL: https://misskey.social
  • Misskey: 13.13.2

🛰 Backend (for server admin)

  • Installation Method or Hosting Service: docker compose,
  • Misskey: 13.13.2
@tassoman tassoman added the ⚠️bug? This might be a bug label Jun 30, 2023
@syuilo
Copy link
Member

syuilo commented Jul 2, 2023

登録前の時点では現状登録しようとしている人が何の言語を使っているかは分からないからまずそこを改修する必要があるな

@tamaina
Copy link
Contributor

tamaina commented Jul 2, 2023

クライアント側では言語が検出できているのだから、Eメール送信を叩く前のAPIリクエストで言語を知らせればいいのでは

(ところでサーバー側でロケールテキストを読み出す方法ってあったっけ)

@tassoman
Copy link
Contributor Author

tassoman commented Jul 2, 2023

I expect you can use browser's language, detected inside the frontend, then pass to the backend at time of registration of disabled account. When the person triggers register button. 🤔

@KisaragiEffective KisaragiEffective added ✨Feature This adds/improves/enhances a feature packages/backend Server side specific issue/PR i18n Internationalization (i18n) related issue/PR and removed ⚠️bug? This might be a bug labels Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨Feature This adds/improves/enhances a feature 🔥high priority i18n Internationalization (i18n) related issue/PR packages/backend Server side specific issue/PR
Projects
Development

No branches or pull requests

4 participants