Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frontend/AiScript): Ui:C:selectの値が切り替わらない問題を修正 #15184

Merged
merged 2 commits into from
Jan 4, 2025
Merged

fix(frontend/AiScript): Ui:C:selectの値が切り替わらない問題を修正 #15184

merged 2 commits into from
Jan 4, 2025
+15 −5

Conversation

kakkokari-gtyih
Copy link
Contributor

What

かいてあるとおり
おそらくネイティブの<select>タグを使わなくなったタイミングで発生したバグ

Why

Fix #15180

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Dec 28, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 19.31%. Comparing base (3c81926) to head (4877c2a).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/components/MkAsUi.vue 0.00% 14 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##           develop   #15184       +/-   ##
============================================
- Coverage    39.96%   19.31%   -20.65%     
============================================
  Files         1563      728      -835     
  Lines       197878   103881    -93997     
  Branches      3646      991     -2655     
============================================
- Hits         79080    20066    -59014     
+ Misses      118193    83261    -34932     
+ Partials       605      554       -51

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuriha-chan yuriha-chan mentioned this pull request Jan 1, 2025
Closed
5 tasks
@mi-gh-maintainer mi-gh-maintainer bot merged commit f4e0251 into misskey-dev:develop Jan 4, 2025
22 checks passed
@mi-gh-maintainer mi-gh-maintainer
Copy link

Thank you 🙏

@kakkokari-gtyih kakkokari-gtyih deleted the fix-15180 branch January 4, 2025 06:06
Ruruke pushed a commit to Ruruke/misskey that referenced this pull request Jan 4, 2025
@kakkokari-gtyih @Ruruke
fix(frontend/AiScript): Ui:C:selectの値が切り替わらない問題を修正 (misskey-dev#15184)
75a707a 
* fix(frontend/AiScript): Ui:C:selectの値が切り替わらない問題を修正

* Update Changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
packages/frontend Client side specific issue/PR
Projects
[実験中] 管理用
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ui:C:selectの表示値が選択した値に切り替わらない
1 participant
@kakkokari-gtyih