Skip to content
This repository has been archived by the owner on Jul 31, 2024. It is now read-only.

there is a bug in vtransformer, lidar points is changed in this line #419

Closed
brucejiangsaic opened this issue May 23, 2023 · 1 comment
Closed

Comments

@brucejiangsaic
Copy link

brucejiangsaic commented May 23, 2023

cur_coords -= cur_lidar_aug_matrix[:3, 3]

cur_coords = points[b][:, :3]
cur_coords use memory of points, and conducted a inplace-subtract
I run code in torch1.12. lidar points was changed here and would not match GT

@JingweiZhang12
Copy link

JingweiZhang12 commented May 23, 2023

Yeah, I also found it. However, in float16 mode, the decorator @auto_fp16 in MMCV will deep copy the points and bypass this potential bug, so the points is not modified in-place. In float32 mode, this bug occurs.
Solution: the points here could be replaced by copy.deepcopy(points)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants