-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No check for equal proportions in plot #10
Comments
Perhaps I'm missing something here, but is there a general requirement for the coordinates to be fixed? The arrows point to the same location in both plots, but have different angles when the plot's aspect ratio changes. I think this behaviour is expected when working with It is definitely worth mentioning that when the arrow's angles are important, that using equal coordinate ratios for |
Thanks for the reprex and clear explanation by the way! 🎉 |
No problem, maybe it is not the case for all applications, for most applications I could see for the arrows the direction does matter. I encountered this when a student had some code where the arrows were pointing in a "wrong" direction. In our case it was a time series of vectors. As I know the |
For wind fields, I imagine it will be plotted on a map which would use the appropriate map coordinates. Perhaps I could add a message when the default ggplot2 coordinate space is used with geom_quiver(), suggesting that the angles may not be what is expected unless coord_equal() is used. |
In this case we were interested in a timeseries of wind to that is why the map did not have dimensions. I think that warning/message sounds sensible. |
I just encountered this case, it seems
geom_quiver
does not check if the dimensions are equal between X and Y. This causes a problem that the directions of the arrows do not correct. This is easily fixable by usingcoord_equal
orcoord_fixed
but it might be good to warn users to do so. Maybe it can be checked if the coord inheritsCoordFixed
, maybe a check for the ratio would also be good? (The first plot is incorrect)Created on 2022-03-07 by the reprex package (v2.0.1)
The text was updated successfully, but these errors were encountered: