Comment errors (#60)

Handle violation type of "Error".
Set default threshold to 0

src/index.ts

@@ -54,7 +54,7 @@ function initialSetup() {
   const inputs: PluginInputs = {
     reportMode: getInput("report-mode") || "check-runs",
     customPmdRules: getInput("custom-pmd-rules"),
-    severityThreshold: parseInt(getInput("severity-threshold")) || 4,
+    severityThreshold: parseInt(getInput("severity-threshold")) || 0,
     strictlyEnforcedRules: getInput("strictly-enforced-rules"),
     deleteResolvedComments: getInput("delete-resolved-comments") === "true",
     target: context?.payload?.pull_request ? "" : getInput("target"),
@@ -131,7 +131,6 @@ function filterFindingsToDiffScope(
   console.log(
     "Filtering the findings to just the lines which are part of the pull request..."
   );
-  let hasHaltingError = false;
 
   for (let finding of findings) {
     const filePath = finding.fileName.replace(process.cwd() + "/", "");
@@ -141,18 +140,9 @@ function filterFindingsToDiffScope(
       if (!isInChangedLines(violation, relevantLines) && !inputs.target) {
         continue;
       }
-
-      const { violationType } = reporter.translateViolationToReport(
-        filePath,
-        violation,
-        finding.engine
-      );
-      if (violationType === "Error") {
-        hasHaltingError = true;
-      }
+      reporter.translateViolationToReport(filePath, violation, finding.engine);
     }
   }
-  return { hasHaltingError };
 }
 
 /**

src/reporter/annoations-reporter.ts

@@ -118,6 +118,5 @@ export class AnnotationsReporter extends BaseReporter<GithubAnnotation> {
       message: `${violation.category} ${violation.message}\n${violation.url}`,
       title: `${violation.ruleName} (sev: ${violation.severity})`,
     });
-    return { violationType };
   }
 }

src/reporter/comments-reporter.ts

@@ -22,6 +22,8 @@ import {
 } from "./reporter.types";
 import { ScannerViolation } from "../sfdxCli";
 
+const ERROR = "Error";
+
 const HIDDEN_COMMENT_PREFIX = "<!--sfdx-scanner-->";
 
 export class CommentsReporter extends BaseReporter<GithubComment> {
@@ -198,6 +200,9 @@ export class CommentsReporter extends BaseReporter<GithubComment> {
       violation,
       engine
     );
+    if (violationType === ERROR) {
+      this.hasHaltingError = true;
+    }
     const commit_id = this.context.payload.pull_request
       ? this.context.payload.pull_request.head.sha
       : this.context.sha;
@@ -217,7 +222,6 @@ export class CommentsReporter extends BaseReporter<GithubComment> {
         commit_id
       ),
     });
-    return { violationType };
   }
 
   /**

src/reporter/reporter.types.ts

@@ -74,7 +74,7 @@ export interface Reporter {
     filePath: string,
     violation: ScannerViolation,
     engine: string
-  ): { violationType: string };
+  ): void;
 }
 
 type GithubCommentSide = "RIGHT";
@@ -98,7 +98,7 @@ export abstract class BaseReporter<T> implements Reporter {
     _filePath: string,
     _violation: ScannerViolation,
     _engine: string
-  ): { violationType: string } {
+  ): void {
     throw new Error("Method not implemented.");
   }