Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update git-actions.ts #72

Merged
merged 2 commits into from
Jan 13, 2024

Conversation

walter-barreiro
Copy link
Contributor

@walter-barreiro walter-barreiro commented Jan 4, 2024

Double quotation marks have been added to solve the problem that occurs when the branch name contains parenthesis or apostrophe.
#71

Double quotation marks have been added to solve the problem that occurs when the branch name contains parenthesis or apostrophe.
src/git-actions.ts Outdated Show resolved Hide resolved
Copy link
Owner

@mitchspano mitchspano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is missing the execution of the build step which will transpile the TS into JS:

https://github.com/mitchspano/sfdx-scan-pull-request?tab=readme-ov-file#making-modifications

@mitchspano mitchspano merged commit e990546 into mitchspano:main Jan 13, 2024
@AsdrubalHikko
Copy link

AsdrubalHikko commented Feb 1, 2024

Hi @mitchspano, is there an ETA on when this fix will be available in the marketplace? Thanks

@mitchspano
Copy link
Owner

This fix is now available in release v0.1.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants