-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deep linking to controls #348
Comments
Explore if it is possible to implement this without impacting the existing functionality of being able to view different controls, make changes that possibly aren't changed and to go back to those controls without losing what was changed. What we don't want is to click on a control and to be redirected to a new page every time but at the same time be able to link to a specific control. |
one option that comes in mind is to add a target attribute to the control to open the link in a new tab. But, I am not sure if I really understand the ask. |
Also looking at the routes: resources :components, only: %i[show create update destroy], shallow: true do
post 'lock', to: 'reviews#lock_controls'
resources :rules, only: %i[index show create update destroy], shallow: true do
post 'revert', on: :member
resources :comments, only: %i[create]
resources :reviews, only: %i[create]
end
end We use the option resources :components, only: %i[show create update destroy], shallow: true do
post 'lock', to: 'reviews#lock_controls'
resources :rules, only: %i[index create update destroy], shallow: true do
post 'revert', on: :member
resources :comments, only: %i[create]
resources :reviews, only: %i[create]
end
end
# Separate route for rules#show
get '/components/:component_id/rules/:id', to: 'rules#show', as: 'component_control' |
Couple uses cases. If i just want to have someone else look at a specific control I can't send them a direct link to it. The second thing is for the notification system if we notify someone on an @ mention or a review request we should also be able to provide a link to the control/comment they were mentioned or the control they were asked to review. |
Feature request for the backlog
Links directly to controls for sending directly to users outside of Vulcan.
When on a control the URL is like this currently:
https://vulcan/components/5/controls
Looking for something like this to go directly to a control via the URL.
https://vulcan/components/5/controls/ESXI-70-000001
The text was updated successfully, but these errors were encountered: