Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't load enoki through meson #135

Open
tbttfox opened this issue Oct 30, 2024 · 0 comments
Open

Can't load enoki through meson #135

tbttfox opened this issue Oct 30, 2024 · 0 comments

Comments

@tbttfox
Copy link

tbttfox commented Oct 30, 2024

The CMakeLists.txt file adds the enoki include directory, but does so at the global level, so there's no base-level target created.
This makes it impossible to load enoki through the cmake interface in meson.
And also, it feels like one of those "good practice" things.

However, I really don't expect any action on this since it would force essentially meaningless updates on all existing downstream packages (plus the source hasn't been updated in 4 years)
It's mostly for people searching this in the future.

And for those future people: CMakeLists.txt would need something like this instead of the global include_directories call.

add_library(enoki INTERFACE)
target_include_directories(enoki INTERFACE include)

Then I think all the other libraries like enoki-cuda would have to link to enoki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant