-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement request: streamline multiblock functions by removing scheme
and init
args
#336
Closed
4 of 5 tasks
Labels
feature-request
Can be implemented if there's enough interest
Comments
Comparing run time of Basically shows very little difference in runtime so will stick to
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
In the multiblock functions you can choose the
scheme
and for thehorst
scheme you can choose theinit
(svd.single
orsvd
). As discussed with Kim-Anh today users only use thehorst
scheme so lets hardcode this scheme into the function.init
is by defaultsvd.single
but lets hardcode it as whichever runs faster.This will streamline this function and prevent confusion as these additional arguments are not described/explained extensively in documentation.
Functions that this affects:
✅
block.pls()
✅
block.spls()
✅
block.plsda()
✅
block.splsda()
==wrapper.sgccda()
✅
mint.block.pls()
✅
mint.block.spls()
✅
mint.block.plsda()
✅
mint.block.splsda()
✅
wrapper.rgcca()
✅
wrapper.sgcca()
Process:
✅ Check whether
svd.single
orsvd
runs faster for each functionscheme = horst
andinit = svd.single
perf()
andtune()
The text was updated successfully, but these errors were encountered: