Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HELP] how to compile? #375

Closed
KnIfER opened this issue May 5, 2021 · 2 comments
Closed

[HELP] how to compile? #375

KnIfER opened this issue May 5, 2021 · 2 comments

Comments

@KnIfER
Copy link

KnIfER commented May 5, 2021

yarn install

result:

var TurndownService = (function (domino) {
  'use strict';
……

What is domino?

@martincizek
Copy link
Collaborator

martincizek commented May 5, 2021

domino is a DOM implementation. It is a dependency conditionally included in Node.js (non-browser) build. Unfortunately I haven't tried Turndown with yarn, but npm dependency should respect browser vs. non-browser usage, see #334.

In general:

  • you need the build dependent on domino if you are not running in browser
  • you should use the build not dependent on domino in browser, as browsers have their own DOM implementation indeed

@martincizek
Copy link
Collaborator

If this is a question, then it's answered.
If this is something like #378, then it's fixed in 7.1.1.
Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants