Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Scratch" control should correlate to the deck speed at all times #5350

Closed
mixxxbot opened this issue Aug 22, 2022 · 6 comments
Closed

"Scratch" control should correlate to the deck speed at all times #5350

mixxxbot opened this issue Aug 22, 2022 · 6 comments
Labels

Comments

@mixxxbot
Copy link
Collaborator

mixxxbot commented Aug 22, 2022

Reported by: Pegasus-RPG
Date: 2010-03-01T20:14:09Z
Status: Fix Released
Importance: Wishlist
Launchpad Issue: lp530281
Tags: pitch, scratch, scratching, vinyl


It would be ideal if the scratch control would work the same regardless of whether the deck is playing or not. Specifically, can it be the "master control" for a deck such that setting play to 1 merely sets scratch to 1? (and lights the play button, etc.) Right now, we can't slow a playing track below the play speed without stopping it first while simultaneously setting scratch=1, which is a very messy hack. (That's how the SCS.3d's vinyl2 mode works.)

More info:
currently when play==1 and scratch==0, deck speed==pitch.
When play==0 and scratch==0, deck speed==0.
But when play==1 and scratch==-0.001, speed==-1.001, so there's no way to get deck speed to be -1<speed<1 without first stopping it.

@mixxxbot
Copy link
Collaborator Author

Commented by: asantoni
Date: 2010-03-01T20:34:54Z


Yeah, this behaviour sounds like it'd be handy for vinyl control too...

On Mon, Mar 1, 2010 at 12:14 PM, Pegasus wrote:

Public bug reported:

It would be ideal if the scratch control would work the same regardless of whether the deck is playing or not. Specifically, can it be the "master control" for a deck such that setting play to 1 merely sets scratch to 1? (and lights the play button, etc.) Right now, we can't slow a playing track below the play speed without stopping it first while simultaneously setting scratch=1, which is a very messy hack. (That's how the SCS.3d's vinyl2 mode works.)
(More info: currently when play==1 and scratch==0, deck speed==pitch. When play==0 and scratch==0, deck speed==0. But when play==1 and scratch==-0.001, speed==-1.001, so there's no way to get deck speed to be -1<speed<1 without first stopping it.)

** Affects: mixxx
    Importance: Wishlist
        Status: New

** Tags: pitch scratch scratching vinyl

** Description changed:

  • It would be ideal if the scratch control would work the same regardless of if the deck is playing or not. Specifically, can it be the "master control" for a deck such that setting play to 1 merely sets scratch to 1? (and lights the play button, etc.) Right now, we can't slow a playing track below the play speed without stopping it first while simultaneously setting scratch=1, which is a very messy hack. (That's how the SCS.3d's vinyl2 mode works.)
  • It would be ideal if the scratch control would work the same regardless of whether the deck is playing or not. Specifically, can it be the "master control" for a deck such that setting play to 1 merely sets scratch to 1? (and lights the play button, etc.) Right now, we can't slow a playing track below the play speed without stopping it first while simultaneously setting scratch=1, which is a very messy hack. (That's how the SCS.3d's vinyl2 mode works.)
     (More info: currently when play==1 and scratch==0, deck speed==pitch. When play==0 and scratch==0, deck speed==0. But when play==1 and scratch==-0.001, speed==-1.001, so there's no way to get deck speed to be -1<speed<1 without first stopping it.)

--
"Scratch" control should correlate to the deck speed at all times
https://bugs.launchpad.net/bugs/530281
You received this bug notification because you are a member of Mixxx
Development Team, which is subscribed to Mixxx.

@mixxxbot
Copy link
Collaborator Author

Commented by: Pegasus-RPG
Date: 2010-03-10T13:31:08Z


Fix committed in fixes_scratch branch. Vinyl control needs to be adjusted to work with it though.

@mixxxbot
Copy link
Collaborator Author

Commented by: Pegasus-RPG
Date: 2010-04-07T06:29:59Z


Let me explain the fix:

There is now a scratch_enable ControlObject that you set to 1 when you want the scratch CO to override the playback speed, which happens regardless of play status. Then you use the scratch CO to directly manipulate the deck speed. Setting scratch to 0 brings the deck to a stop, as it should. To disable scratching, set scratch_enable to 0. (In 1.7, setting scratch to 0 disabled scratching.) If scratch_enable is 0, changing scratch has no effect.

(So this doesn't work exactly like I proposed in the bug description, but it was more straightforward to code and solves the problem that precipitated this bug report.)

@mixxxbot
Copy link
Collaborator Author

Commented by: Pegasus-RPG
Date: 2010-05-13T14:45:12Z


fixes_scratch has been merged to trunk. "scratch" still works as in 1.7, but "scratch2" and "scratch2_enable" implement this new behavior.

@mixxxbot
Copy link
Collaborator Author

Commented by: Pegasus-RPG
Date: 2016-10-01T14:28:35Z


If this also affects another project, click "also affects project." Don't change the original project. (Why are you changing this old bug anyway?)

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant