Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2025 Reefscape field image / Processor alignment reference off by 36 pixels for Red alliance #1030

Closed
roberttuttle opened this issue Jan 26, 2025 · 3 comments · Fixed by #1040
Labels
bug Something isn't working

Comments

@roberttuttle
Copy link

roberttuttle commented Jan 26, 2025

The visual alignment marker present in the field image for the red processor is off by 36 pixels as compared to the pose coordinates to the center of the associated AprilTag. It appears that marker was drawn / placed to have its center on the start of the processor station as opposed to representing the center of the processor scoring element (which is represented by the associated AprilTag center).

@roberttuttle roberttuttle added the bug Something isn't working label Jan 26, 2025
@roberttuttle roberttuttle changed the title 2025 Reefscape field image / Processor alignment reference off by 36 pixels for both alliances 2025 Reefscape field image / Processor alignment reference off by 36 pixels for Red alliance Jan 26, 2025
@roberttuttle
Copy link
Author

It looks like the Blue processor marker in the image is also off, so I will try to help out by fixing both and submitting a PR.

@mjansen4857
Copy link
Owner

I’ll be able to get to fixing the images fairly soon. To accept a PR for that I’d want the source assets to be updated as well, which uses affinity photo. If you don’t have that then I can fix them, it’s a pretty minor change.

@roberttuttle
Copy link
Author

Cool ... no problem waiting for the source of truth fixes then. I wanted to offer to fix it since "complaining" about 36 pixels in the grand scheme of things is obviously minor. 😉

@mjansen4857 mjansen4857 linked a pull request Jan 27, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants