Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control Length of 0 distance becomes NaN (Breaks & Crashes GUI) #662

Closed
Derp88 opened this issue Mar 25, 2024 · 2 comments
Closed

Control Length of 0 distance becomes NaN (Breaks & Crashes GUI) #662

Derp88 opened this issue Mar 25, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Derp88
Copy link

Derp88 commented Mar 25, 2024

Describe the bug
The point heading and control length can become NaN (Not A Number) if the control point is dragged on top of the anchor point (Control Length is then 0). Once the value becomes NaN, it cannot be changed back to a proper number.

To Reproduce

  1. Drag a control point to be exactly on top an anchor point (Next Control Length = 0)
  2. Try to change the the current Next Control Length to a number besides 0 by typing in a new number
  3. Next Control Length will now become NaN
  4. It is now impossible to change the value from NaN and if you attempt to do so the generated robot path disappears.
  5. If you leave and try to re-open the path, PathPlanner GUI will crash.

Expected behavior

  • The value should not become NaN when changed from 0 to another number
  • Maybe have a way to separate overlapping anchor and control points?

Screenshots
Setting the control point on top of the anchor point (by dragging it)
image
Trying to change length to a non-zero value (1 in this case), it instead becomes NaN
image
Simulated Driving Time and the time on the time bar also become NaN
image

Versions:

  • OS: Windows 10
  • GUI Version: 2024.1.6
  • PPLib Version: 2024.2.7
  • PPLib Language: Java

Additional context
This happened because I accidently put the control point on top of the anchor point. I couldn't figure out any way to move the control point besides changing the value for length as you cannot drag it off if the 2 points overlap.

@Derp88 Derp88 added the bug Something isn't working label Mar 25, 2024
@ModBoyex
Copy link

ModBoyex commented Apr 1, 2024

Yes, I ran into this too because I was trying to make a python script that would write some autos, and it did this exact thing by accident and there no way to move it off.

@mjansen4857
Copy link
Owner

Fixed in #774

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants