Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why doesn't the MJML app use the latest version of MJML? #275

Closed
torncheesecake opened this issue Dec 7, 2018 · 6 comments
Closed

Why doesn't the MJML app use the latest version of MJML? #275

torncheesecake opened this issue Dec 7, 2018 · 6 comments

Comments

@torncheesecake
Copy link

As the title says, why doesn't the MJML app use the latest version of MJML? Currently my app is using 4.1.2, anything I do to try and point it to a custom engine doesn't work. But the app should really auto update to using the current latest version of MJML, much like browsers etc do and other programs do with updates like Atom.

@medarob
Copy link

medarob commented Dec 7, 2018

That would be good! I wonder myself why the App is not up-to-date...

@vicmunez85
Copy link

Ditto, This would be amazing. I see releases with new features but no updates to the app :(

@ngarnier
Copy link
Member

ngarnier commented Dec 7, 2018

Indeed, the update of MJML version is not automatic so we have to do it manually: update the MJML version, do some potential updates based on the changes internal to MJML, build the app for each OS and release.

Feel free to contribute by proposing a way to automate this flow.

@torncheesecake
Copy link
Author

Feel free to contribute by proposing a way to automate this flow.

I'm assuming because atom is a github program that it uses some checking script and pull to update the version. I've noticed that there is a github feature coming so maybe that might help the project.

@keberox
Copy link

keberox commented Feb 21, 2019

Since the app is using Electron, I believe this should not be difficult to accomplish - having the app use the latest version of the MJML engine.

@kmcb777
Copy link
Contributor

kmcb777 commented Mar 13, 2019

Hi @matthewahillman @medarob @vicmunez85 @keberox , a new app release is available with mjml4.3.1, feel free to try it out !

@kmcb777 kmcb777 closed this as completed Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants