-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to filter available testsets by language pair #211
Conversation
Using ``` sacrebleu --list -l en-fr ``` test sets available in English-French are listed.
Please let me know if something with codestyle or style of implementation is wrong and I will change it. Hope it is useful! |
I thought |
Thanks! Can you give me write permission to your branch, so I add a few small changes (e.g., I updated the CHANGELOG). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the PR!
@ZJaume Let me know if you can give me write access. If so, I'll push up a few changes and merge. If not, I'll have to create a local branch and have someone else approve it. |
There you go! I gave you collaborator access to my fork. |
Thanks very much! I'll release this with 2.2.2 soon. |
Implement #210
Using
test sets available in English-French are listed.
tests are passing.
Some examples:
Swapping the language pair gives the same output for consistence with download, that is able to find the set regardless of direction I guess.