I tried display custom object in a block.

[tao-s]

This add-on is great !

Today, I created a custom block for this add-on.
Is this way correct ?
https://gist.github.com/tao-s/9742395

Please give me a response.

[mkly]

Hello,
I haven't finished the interface to that. I am open to adding a getAttribute() method to the data class. This is what I currently do.

// Attribute Handle my_data_attribtue
$data->myDataAttribute->getValue('display');

That said, as soon as I get time I am going to add a getAttribute() method that works like the User, File etc.

This test shows a bit about setting and getting attribtues
https://github.com/mkly/Data/blob/master/tests/tests/models/data.php#L49-L64

[mkly]

Adding this as enhancement as a getAttribute() method should be implemented.

[tao-s]

Thank you mkly.

That said, as soon as I get time I am going to add a getAttribute() method that works like the User, File etc.

That sounds great.
OK, I wait it.
The Japanese team will looking forward to it.

Is there something that we can help with?

[mkly]

Any ideas you might have to make it more useful to you would be great. If you are looking for things to add, you can try adding getAttribute(). I was just going to make it work like
https://github.com/concrete5/concrete5/blob/master/web/concrete/core/models/userinfo.php#L349-L366
Maybe I would write the code different. But the same method interface.

There's also #11 as search could be a lot better.

But most important is just letting me know any ideas you might have to make it better.

Thanks for the encouragement,
Mike

[tao-s]

OK, I'll ask to Japanese team what have any good ideas about that.