Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feet prediction quality #24

Closed
kallivad opened this issue Feb 4, 2020 · 6 comments
Closed

Feet prediction quality #24

kallivad opened this issue Feb 4, 2020 · 6 comments
Assignees

Comments

@kallivad
Copy link

kallivad commented Feb 4, 2020

Dear @mkocabas Thank you for the great work!
I have watched and analysed a number of indoor videos which illustrate the approach, and it looks like while the reconstruction results overall are impressive,
there is still a number of leg positioning drawbacks, especially noticeable in feet pose detection.

frame3120

frame6100

frame7359

In some frames feet are not detected correctly, on most of incorrectly predicted frames leg toes are raised up. IMHO, it is likely that all net contraction trained with poor feet labeling. Is it correct assumption?

frame10323

frame10905

frame11467

Now I am in the process of understanding what is the root cause of this issue, and what can be done
in order to alleviate feet prediction error.
I see that you predictor has convolutional backbone inherited from the SPIN solution.
https://github.com/nkolot/SPIN
But I haven't figured out on what data and with what labelling it is trained with?
I mean, does it have only one feet joint or several? Have you retrained SPIN on your datasets?
And in case of retraining CNN backbone, is it necessary to retrain the temporal part of VIBE too?
Or perhaps I can leave it untouched for a while?
Thanks a lot in advance, I would greatly appreciate your response.

@ikvision
Copy link

ikvision commented Feb 4, 2020

Some of the results you show above may be improved by cropping using a larger bounding box
https://github.com/nkolot/SPIN/blob/b95a00a7c0147f2c5bee0874ba0972c6389b6f99/demo.py#L86, but tuning bounding box is a limited solution and re-training is more beneficial.

SPIN is trained with multiple losses, the relevant ones I think are:

  • keypoint_loss: Compute 2D reprojection L2 loss on the keypoints
  • Keypoint_3d_loss: Compute 3D keypoint L2 loss for the examples that 3D keypoint annotations are available

according to nkolot/SPIN#39 (comment) ground truth keypoints include Ankle, but do not include keypoint on the feet.

OpenPose includes 2 key points on the feet, but openpose_train_weight is set to zero by default.
When trying to train with openpose_train_weight > 0 the model results deteriorated, probably due to nkolot/SPIN#43 (comment)

I think it is a shared gap of SPIN and VIBE, therefore I don't think it is related to the GRU (temporal) part of VIBE.

@ikvision
Copy link

ikvision commented Feb 5, 2020

Some papers suggest foot velocity loss
eg: https://arxiv.org/abs/1905.01680
image

@kallivad
Copy link
Author

kallivad commented Feb 5, 2020

@ikvision Thank you a lot for clarification!

@atnikos atnikos self-assigned this Feb 14, 2020
@atnikos atnikos closed this as completed Feb 14, 2020
@atnikos atnikos reopened this Feb 14, 2020
@mkocabas
Copy link
Owner

mkocabas commented Mar 9, 2020

Thanks for the discussion @kallivad and @ikvision.

During training of the released pretrained models, we didn't incorporate openpose feet keypoint predictions to the projected 2d keypoint loss. We plan to incorporate those to improve feet accuracy which would be helpful to some extent.

@mkocabas mkocabas closed this as completed Mar 9, 2020
@Tetsujinfr
Copy link

Tetsujinfr commented Mar 31, 2020

Do you have an idea on when you would release the feet enhancement? I think it would help a lot to improve further the overall quality of the poses estimations. Thanks for the great work.

@atnikos
Copy link
Collaborator

atnikos commented Mar 31, 2020

That is true. We are trying to find a workaround for this. Either better feet keypoints or a constraint. We don't have a precise estimate, right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants