Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: optional scrolling for print API #45

Merged
merged 2 commits into from
Aug 15, 2024
Merged

feat: optional scrolling for print API #45

merged 2 commits into from
Aug 15, 2024

Conversation

mkrl
Copy link
Owner

@mkrl mkrl commented Aug 15, 2024

Description

Adds an ability to disable scrollIntoView when calling print

terminal.print(text, isCommand = false, scrollIntoView = true)

Providing false (it is true by default) disables scrolling the input into view when a text is printed.

Fixes # #44

Pre-review checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (if required)
  • My contribution is awesome

@mkrl mkrl added the enhancement New feature or request label Aug 15, 2024
@mkrl mkrl self-assigned this Aug 15, 2024
@mkrl mkrl merged commit 6b0fffd into master Aug 15, 2024
2 checks passed
@mkrl mkrl deleted the optional-scrolling-for-print-44 branch August 15, 2024 21:18
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mkrl mkrl mentioned this pull request Aug 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mkrl mkrl

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mkrl