fix(#80): AuthInterceptor implementation is incomplete #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nivisi
changed the title
…mentation-is-incomplete
johsoe
suggested changes
Jan 19, 2023
| @@ -11,9 +12,21 @@ class AuthTokens with _$AuthTokens { | |||
| required String refreshToken, | |||
| required String tokenType, | |||
| required double expiresIn, | |||
There was a problem hiding this comment.
Hmm, do we ever get this tbh? Shouldn't it just be expiresAt
There was a problem hiding this comment.
@johsoe in all the projects I've worked on we used expiresIn
There was a problem hiding this comment.
Do we use expiresAt on other projects?
There was a problem hiding this comment.
If that's the case, we should probably remove expiresAt - we shouldn't have both
johsoe
approved these changes
Aug 24, 2023
…mentation-is-incomplete # pubspec.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #80
Introduced:
Authenticatorclass that is responsible for:ApiAuthInterceptor, is usingAuthenticatorto reauth if needed.ApiAuthInterceptorclass. It is a rewritten version of the old interceptor — more readable and straightforward. This interceptor is aQueuedInterceptornow — meaning that, if we await for something, other request calls will wait until this call is resolved.Both of the classes are covered with tests. If you think that not all the scenarios are covered — please let me know, I'll add those.
Also, we now use
FlutterSecureStoragefor storing the tokens. It is safer. BUT! This storage survives app uninstallation IIRC. So we should consider creating something that will detect fresh installation and clear the storage. Something like storing a value with thefreshInstallationkey in the shared prefs of the app.Changes with build context and response errors are related to the freezed generator failing to build with
materiallibrary imports..