Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize docker export capabilities #4

Closed
lukasmasuch opened this issue Apr 19, 2021 · 6 comments
Closed

Finalize docker export capabilities #4

lukasmasuch opened this issue Apr 19, 2021 · 6 comments
Labels
feature Request for new feature or improvement stale Awaiting input from creator for prolonged time period

Comments

@lukasmasuch
Copy link
Contributor

Feature description:

Finalize capabilities to export an opyrator to a Docker image.

The export can be executed via command line:

opyrator export my_opyrator:hello_world --format=docker my-opyrator-image:latest

💡 The Docker export requires that Docker is installed on your machine.

After the successful export, the Docker image can be run as shown below:

docker run -p 8080:8080 my-opyrator-image:latest

Running your Opyrator within this Docker image has the advantage that only a single port is required to be exposed. The separation between UI and API is done via URL paths: http://localhost:8080/api (API); http://localhost:8080/ui (UI). The UI is automatically configured to use the API for all function calls.

@lukasmasuch lukasmasuch added the feature Request for new feature or improvement label Apr 19, 2021
@dleunji
Copy link

dleunji commented Apr 30, 2021

Hi. I'm using this Opyrator well, and want to deploy my project in a Docker image. So I tried the command line as you noticed
But I only got a message.
[WIP] This feature is not finalized yet. You can track the progress and vote for the feature here: https://github.com/ml-tooling/opyrator/issues/4 :(
Is it really finalized?

@lukasmasuch
Copy link
Contributor Author

@dleunji the Docker export is not ready yet for release :( But we have prioritized this feature and will update this issue as soon as it is ready for usage.

@amitmtrn
Copy link

Hi, I want to collaborate on this issue, can you tell me if the logic for exporting the docker would be acceptable?

  1. pip freeze to a requirements file
  2. create docker file from python
  3. copy the opyrator file and the requirements (from the freeze)
  4. pip install the requirements (on the docker file)
  5. opyrator launch-ui and opyrator-launch-api (2 ports open on the docker 8080 and 8051)
  6. dump the docker image

@raethlein
Copy link
Member

Hey @amitmtrn, thanks for your thoughts! I think this looks like a good approach and looks like it would be worth trying out :) In the future we could discuss whether it could be better to have an official opyrator image (step 2) instead of using the python base image.

@github-actions
Copy link

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 14 days

@github-actions github-actions bot added the stale Awaiting input from creator for prolonged time period label Oct 22, 2021
@github-actions github-actions bot closed this as completed Nov 6, 2021
@kris-farr
Copy link

Any updates on this, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Request for new feature or improvement stale Awaiting input from creator for prolonged time period
Projects
None yet
Development

No branches or pull requests

5 participants