Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks with node version 12 #11

Closed
SISheogorath opened this issue May 12, 2019 · 2 comments
Closed

Breaks with node version 12 #11

SISheogorath opened this issue May 12, 2019 · 2 comments

Comments

@SISheogorath
Copy link

We just wanted to add node version 12 n our CI chain and had to notice that scrypt broke compatibility with node 12. Is there any intention to make this library compatible with node version 12?

Seems like it simply fails on renamed/changed function names like v8::Value::IntegerValue().

@ml1nk
Copy link
Owner

ml1nk commented May 12, 2019

This fork contains some fixes to the original (long dead) node-scrypt package like issue 185 mostly from other contributors. Since scrypt is native to nodejs with v10.5.0 you should switch to something like scrypt-kdf on anything >=10.5.0.

@SISheogorath
Copy link
Author

Thanks for the hint, we implemented a fix :)

hedgedoc/hedgedoc#66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants