Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explorer small fix #481

Merged
merged 3 commits into from
Oct 5, 2023
Merged

explorer small fix #481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a52b803
explorer small fix
Hakimovich99 Oct 3, 2023
23d6c8d
Update explorer.py
Hakimovich99 Oct 4, 2023
625db5b
Update test_explorer.py
Hakimovich99 Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/fondant/explorer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,12 @@ def run_explorer_app( # type: ignore
"from a cloud provider, mount the credentials file with the --credentials flag.",
)
data_directory_path = Path(base_path).resolve()
host_machine_path = str(data_directory_path)
host_machine_path = data_directory_path.as_posix()
container_path = os.path.join("/", data_directory_path.name)

# Mount the local base path to the container
cmd.extend(
["-v", f"/{shlex.quote(host_machine_path)}:/{shlex.quote(container_path)}"],
["-v", f"{shlex.quote(host_machine_path)}:{shlex.quote(container_path)}"],
)

# add the image name
Expand Down
2 changes: 1 addition & 1 deletion tests/test_explorer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def test_run_data_explorer_local_base_path(host_path, container_path, credential
"-v",
f"{credentials}:ro",
"-v",
f"/{Path(host_path).resolve()}:/{container_path}",
f"{Path(host_path).resolve()}:{container_path}",
f"{DEFAULT_CONTAINER}:{DEFAULT_TAG}",
"--base_path",
f"{container_path}",
Expand Down
Loading