We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi, The following ShellItem is not released if an error is returned while using it (the function jumps to the end):
ShellItem
nativefiledialog/src/nfd_win.cpp
Line 403 in 5cfe500
Similarly, the file dialog itself is never released.
Compare it to the official example.
The text was updated successfully, but these errors were encountered:
I agree, this needs doing! If you offer a PR, I would be happy to merge it.
https://github.com/mlabbe/nativefiledialog/blob/master/docs/submitting_pull_requests.md
Sorry, something went wrong.
Friendly bump. If you have any time, I'd appreciate it.
Thanks for the reminder. I have a busy period at the moment and I'm not sure I'll be able to do it in January. I'll send a PR once I have more time.
Could maybe switch to use the RAII objects - the ComPtr would auto call release in any circumstance
I implemented a fix for all of the cases on the devel branch.
No branches or pull requests
Hi,
The following
ShellItem
is not released if an error is returned while using it (the function jumps to the end):nativefiledialog/src/nfd_win.cpp
Line 403 in 5cfe500
Similarly, the file dialog itself is never released.
Compare it to the official example.
The text was updated successfully, but these errors were encountered: