Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMake project #50

Closed
irov opened this issue Jul 2, 2018 · 3 comments
Closed

Add CMake project #50

irov opened this issue Jul 2, 2018 · 3 comments

Comments

@irov
Copy link

irov commented Jul 2, 2018

can I create a pull request and add to this project CMakeLists.txt?

@mlabbe
Copy link
Owner

mlabbe commented Jul 3, 2018

Given that there are Premake-generated projects for each platform and architecture that is supported, we do not need Cmake. Some of the original reasoning is available in this blog post:

https://www.frogtoss.com/labs/premake-for-package-maintainers.html

Adding Cmake in addition to Premake would increase the maintenance overhead and I already do not have a lot of free time. I am not likely at all to accept a Premake pull request as a result of all these reasons.

@minexew
Copy link

minexew commented Dec 29, 2020

@irov I think a battle-tested CMakeLists.txt would be very much appreciated by the community even if not upstreamed into the main project :))

@mlabbe
Copy link
Owner

mlabbe commented Jan 8, 2021

There is an unofficial cmake file in vcpkg you can work with. https://github.com/microsoft/vcpkg/tree/master/ports/nativefiledialog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants