Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac: file filters ignored when after longer extension #66

Closed
szakeetm opened this issue Mar 4, 2019 · 3 comments
Closed

Mac: file filters ignored when after longer extension #66

szakeetm opened this issue Mar 4, 2019 · 3 comments
Labels

Comments

@szakeetm
Copy link

szakeetm commented Mar 4, 2019

I call an NFD_OpenDialog with file filters "txt,html,htm"
On Windows and Linux, this behaves as expected.
On MacOS Mojave, I can only select txt and html files, not htm (they are greyed out).
When I change the filters to "txt,htm,html" it works.
It seems that a file filter extension is ignored if it's defined after an other extension with a larger number of characters.

@mlabbe
Copy link
Owner

mlabbe commented Mar 6, 2019

This looks like a bug! If you can put together a fix for it, I will accept the PR. Here are the guidelines:

https://github.com/mlabbe/nativefiledialog/blob/master/docs/submitting_pull_requests.md

Thanks!

@mlabbe mlabbe added the bug label Mar 6, 2019
@mlabbe
Copy link
Owner

mlabbe commented Sep 28, 2019

Fixed f939b05

@mlabbe mlabbe closed this as completed Sep 28, 2019
@szakeetm
Copy link
Author

Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants