Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileInput default icon is download, should be file_upload #1325

Closed
stickfigure opened this issue Dec 27, 2021 · 1 comment
Closed

FileInput default icon is download, should be file_upload #1325

stickfigure opened this issue Dec 27, 2021 · 1 comment
Labels
bug
Milestone
v4.0.3

Comments

@stickfigure
Copy link
Contributor

FileInput.tsx line 100, looks like the wrong icon. Should be an upload icon, not a download icon.

react-md 4.0.2
@stickfigure stickfigure changed the title FileInput default icon is download, should be upload FileInput default icon is download, should be file_upload Dec 27, 2021
@mlaursen mlaursen added this to the v4.0.3 milestone Dec 31, 2021
@mlaursen
Copy link
Owner

Whoops -- I'll update the default download icon to be file_upload instead of file_download.

In the next major release, I'll rename the download icon to be upload so the naming matches better. The renaming is really only a breaking change if users of this library override these icons like my documentation website or the examples in this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v4.0.3
Development

No branches or pull requests
2 participants
@stickfigure @mlaursen