Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon names are off by one within the material icons docs. #1423

Closed
arminbro opened this issue Aug 4, 2022 · 2 comments
Closed

Icon names are off by one within the material icons docs. #1423

arminbro opened this issue Aug 4, 2022 · 2 comments

Comments

@arminbro
Copy link

arminbro commented Aug 4, 2022

Describe the bug A clear and concise description of what the bug is.

  • On the material-icons demo page, I see many of the icon names are off by one so that the previous icon matches up to the following icon in the list.

To Reproduce Steps to reproduce the behavior:

  1. Go to https://react-md.dev/packages/material-icons/demos
  2. Scroll down, and you should see the icons/labels are mismatched by one.

Expected behavior A clear and concise description of what you expected to
happen.

  • The names of the icons should match their associated icons. So if we take a look at the screenshot below, the first icon on the left, should be Archive, and on the right, the label should be ArrowBack.

Screenshots If applicable, add screenshots to help explain your problem.

  • Screen Shot 2022-08-04 at 10 40 50 AM

Desktop (please complete the following information):

  • OS: macOS Monterey (12.4)
  • Browser: FireFox (v103.0.1), Chrome (v104.0.5112.79)
@mlaursen
Copy link
Owner

mlaursen commented Aug 4, 2022

Thanks for reporting this issue. Looks like it was an issue around different order for Object.entries() between node and the browser which caused it to be off after SSR. This fix should be live in about 20 minutes.

@arminbro
Copy link
Author

arminbro commented Aug 4, 2022

Excellent, thanks for the quick turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants