[SelectField] SelectFields totally broken since 1.7.0

[strblr]

Hey,

Since I updated from react-md@1.3.5 to react-md@1.7.0, SelectFields don't work at all.
The app crashes when clicking to expand the item list :

InkContainer.js:89 Uncaught TypeError: Cannot read property 'classList' of undefined
    at InkContainer._this._getKeyboardContainer (InkContainer.js:89)
    at InkContainer._this.focus (InkContainer.js:52)
    at InkedComponent._this.focus (injectInk.js:64)
    at ListItem.focus (ListItem.js:716)
    at _setListItem (SelectField.js:855)
    at commitAttachRef (react-dom.development.js:14804)
    at commitAllLifeCycles (react-dom.development.js:15910)
    [...]

The above error occurred in the <ListItem> component:
    in ListItem (created by SelectField)
    in ul (created by List)
    in List (created by Layover)
    in CSSTransitionGroupChild (created by TransitionGroup)
    in div (created by TransitionGroup)
    in TransitionGroup (created by CSSTransitionGroup)
    in CSSTransitionGroup (created by Layover)
    in Layover (created by Menu)
    in Menu (created by SelectField)
    [...]

My current workaround is to switch back to 1.3.5 (EDIT: 1.5.1 works too, EDIT 2: 1.6.2 is broken like 1.7.0)
After a few tests, I saw that this function in InkContainer.js is never called :

_setContainers = (group) => {
    if (group !== null) {
      // temp workaround for preact
      // https://github.com/mlaursen/react-md/issues/788#issuecomment-419248903
      this.timeout = setTimeout(() => {
        this.timeout = undefined;
        this._inkContainer = findDOMNode(group);
        this._container = this._inkContainer.parentElement;

        if (this._container) {
          this._initOrRemoveEvents(this.props);
        }
      });
    }
  };

Therefore, this._container is undefined here :

_getKeyboardContainer = () => {
    if (this._container.classList.contains('md-text-field-container')) {
      return this._container.querySelector('.md-text-field');
    }

    return this._container;
  };

Version

• React - latest
• React-MD - latest
• Browser - Tested on Firefox & Chrome

[mlaursen]

Looks like I didn't test the preact workaround enough. Sorry.

Since it looks like I would have to do a few more workarounds to get preact working, so I think I'll revert that workaround and re-open #788 to find a better solution.

[mlaursen]

1.7.1 should now be released with the Preact workaround removed (and SelectFields working again)

[strblr]

Thanks for your quick reply. It works fine now !