Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Novel Config Enhancements: Min-P & DRY Penalization #2793

Open
BuildBackBuehler opened this issue Aug 10, 2024 · 0 comments
Labels
feature request New feature or request

Comments

@BuildBackBuehler
Copy link

🚀 Feature

Perhaps not so "novel" at this point. Min P has been integrated into a handful of backends at this point. Works just as one would imagine, acts as a floor for what the sampler will consider as "best response". This typically replaces K.

DRY I know less about, but I guess it comes from the "Don't Repeat Yourself" coding mantra and is a refined, clever formulation that seems to get the job done better than repetition penalty does. As some Redditor explained "it prevents within-sequence verbatim repetition (other solutions are still needed to prevent across-sequence repetition, synonym repetition, list repetition, etc.)."

Ah, no wonder, it is a very DIY origin it seems. oobabooga/text-generation-webui#5677

Motivation

These are definitely solid enhancements that aren't difficult to implement + wouldn't alter/hurt MLC-LLM's current offerings so they should be no-brainers.

Additional context

https://github.com/EricLBuehler/mistral.rs/pull/625/files
https://github.com/EricLBuehler/mistral.rs/pull/637/files

Mistral.rs happened to add this and DRY recently, so I'll just use those as demonstrations of the simplicity of these add-ins.

@BuildBackBuehler BuildBackBuehler added the feature request New feature or request label Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant