Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the Image Classification benchmark ResNet-50 v1 or ResNet-50 v1.5? #432

Closed
matthew-frank opened this issue Jan 5, 2021 · 4 comments
Closed
Labels
image_classification image_classification benchmark

Comments

@matthew-frank
Copy link
Contributor

https://github.com/mlcommons/training/blob/master/image_classification/README.md#1-problem says

This benchmark uses resnet v1.5 to classify images ...

While https://github.com/mlcommons/training/blob/master/image_classification/README.md#structure--loss says

In brief, this is a 50 layer v1 RNN ...

Please clarify in the README.md whether this is actually a v1 or a v1.5 ResNet-50? Perhaps it would help to move the discussion from https://github.com/mlcommons/training/tree/master/image_classification/tensorflow/official/resnet into this top level document?

As I understand it, the difference between "v1" and "v1.5" is typically that in the bottleneck blocks with downsampling v1 puts the stride 2 convolution in the first 1x1 convolution of the bottleneck, while v1.5 puts the stride 2 into the 3x3 convolution of the bottleneck. If this really is a v1.5 network then I believe a better reference for the modification to the v1 network described in Kaiming He's 2015 paper is the blogpost http://torch.ch/blog/2016/02/04/resnets.html.

@johntran-nv johntran-nv added the image_classification image_classification benchmark label Nov 8, 2022
@johntran-nv
Copy link
Contributor

It's v1.5. @sgpyc could you update the appropriate documentation?

@itayhubara
Copy link
Contributor

I create PR: #605

@matthew-frank
Copy link
Contributor Author

I believe PR #590 (earlier #516) also addresses this issue.

@ShriyaPalsamudram
Copy link
Contributor

Closing as the benchmark is dropped from Training benchmark suite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
image_classification image_classification benchmark
Projects
None yet
Development

No branches or pull requests

4 participants