GrantRepo#for_collection_class inst,group soft delete support #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkostin1966
reviewed
Feb 21, 2024
There was a problem hiding this comment.
The flow of the spec is to state the positive “it” then start soft deleting resources. Therefore I would expect to see ….
it "#for_collection_class finds grants" do
expect(repo.for_collection_class(
username: "lauth-group-member",
client_ip: "10.99.3.4",
collection_class: "someclass"
)).to FIND THE GRANT
end
as the second “it” block.
There was a problem hiding this comment.
makes sense. added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed these were missing.
I think after we merge my PRs it'll be time to DRY up these two methods.