Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimmers not added as lights #10

Open
dalomstornado opened this issue May 10, 2022 · 6 comments
Open

Dimmers not added as lights #10

dalomstornado opened this issue May 10, 2022 · 6 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@dalomstornado
Copy link
Contributor

My dimmers are of model = "selflearning-dimmer". Same config (parameters house and unit) as model codeswitch which work fine and added as switch.

  • Dimmers work fine execing in the container and using tdtool.
  • They do no add as lights in HA.
  • They are added as binary sensors in HA.

Any misshaps on my side perhaps?

@dalomstornado
Copy link
Contributor Author

I guess next up is that the mqtt library does not support the messages from type light. "paho.mqtt.client.MQTTMessage object at 0x75fe6680"

What version of HASS did you verify dimmers on? I just tried 2021.12.7 with no luck.

@mliljedahl
Copy link
Owner

To be frank I did not have real access to a dimmer before but now I have and at this stage I can only confirm the dimmer do not work as expected. Will try to have a look at this as soon as possible. Thanks for your post!

@mliljedahl mliljedahl self-assigned this May 20, 2022
@mliljedahl mliljedahl added the bug Something isn't working label May 20, 2022
@mliljedahl mliljedahl added this to the v1.2.2 milestone May 20, 2022
@dalomstornado
Copy link
Contributor Author

That is perfectly all right. I forked your repo. Have some more changes, like using on/off for the dimmers. Have some testing and state reporting left...

@mliljedahl
Copy link
Owner

Feel free to dig a bit further if you want and I can test and release your pr

@mliljedahl
Copy link
Owner

@dalomstornado is there anything I can help with?

@dalomstornado
Copy link
Contributor Author

I have not had much time to look at this lately. But could you perhaps look at making device_event in main.py able to distinguish between dimmer and switches? I just hardcoded my fork for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants