Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pretty sure the results in the paper are because WT leaks future info #3

Open
JannyKul opened this issue Feb 26, 2019 · 4 comments
Open

Comments

@JannyKul
Copy link

I tried implementing this too. 99% certain their implementation has the Wavelet transform leaking info. If you just do LSTM on daily close_price your odds are slightly better than a coin toss, adding WT they jump to around 65%. Running WT by windows so you don't leak info probability drops below 50%. SAE isn't going to recover anything from that.

I kinda elaborated a bit here

would love to hear your thoughts

@timothyyu
Copy link

timothyyu commented Mar 1, 2019

@JannyKul
See the following thread/issue (relevant):
VivekPa/AIAlpha#13 (comment)

I am attempting to avoid this particular issue with the WT by applying it separately to a train-validate-test split as defined in the source article (Bao et al. 2017).

EDIT: I have read your medium article - I am skeptical of the results also, but that is also part of why I am attempting to replicate the results of the paper myself, first hand.

@timothyyu
Copy link

timothyyu commented Mar 1, 2019

Example of scaling and applying the wavelet transform to the train-validate-test split independently:
image
timothyyu/wsae-lstm#7 (comment)

@mlpanda
Copy link
Owner

mlpanda commented Mar 3, 2019

Hey guys, thanks for your comments. I totally agree that the paper most likely used the WT on the entire time-series. It should of course be done in a rolling fashion in which case even generating any profitable returns becomes very difficult. The approach might work on higher frequency data, but on those daily returns there is no chance that this approach works.

@JannyKul
Copy link
Author

@mlpanda agree entirely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants