Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surv => Regr methods have bugs? #414

Closed
bblodfon opened this issue Sep 6, 2024 · 1 comment
Closed

Surv => Regr methods have bugs? #414

bblodfon opened this issue Sep 6, 2024 · 1 comment

Comments

@bblodfon
Copy link
Collaborator

bblodfon commented Sep 6, 2024

Bugs

  • Test row_ids are not correct
  • During predict not the same features as in training (mlr3 new check triggered this, tests now fail):
Error: Learner 'regr.featureless' has received tasks with different columns in train and predict.

Main Pipeline

Subsequent Pipeops

Building Pipeops for the above Pipeops

Action points

  • Which methods do we need to keep?
  • Update/simplify code for the above
@bblodfon
Copy link
Collaborator Author

bblodfon commented Oct 25, 2024

After a session with Andreas, we concluded:

  • Methods omit and delete for handling censoring are easy to manually implement
  • mrl (mean residual lifetime) doesn't work currently (calls $survivalAntiDeriv from distr6), there is a good reference for it - chapter 2.4, Klein (2004) - no reduction technique is documented there though
  • reorder seemed ad-hoc, will not work with newer mlr3 versions as we want to have the same features during training and prediction
  • bj seems possible as a reduction technique (imputes censoring times), works, added a separate issue (Surv => Regr pipeline using Buckley-James imputation #420) for re-implementing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant