Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Complex-Default" option to available default values #392

Open
sebffischer opened this issue Oct 17, 2023 · 2 comments
Open

Add "Complex-Default" option to available default values #392

sebffischer opened this issue Oct 17, 2023 · 2 comments

Comments

@sebffischer
Copy link
Member

Some of the default values in parameter sets can currently not be expressed because they contain expressions. E.g. a parameter seed might be an integer() but the default is sample.int(100). It is currently not possible to specify the default.

Currently people address this differently when implementing learners. A common solution to the above problem is then to say that the parameter has no default, which is not correct. We came to the agreement that we want to specify this using something like a Cmplx_Default token that is also visible in the rd_info output that is shown e.g. in the learner's help page. This then communicates to the user that one has to look in the help page of the upstream function to learn about the parameter's default behaviour.

@mb706
Copy link
Contributor

mb706 commented Oct 17, 2023

The information encoded here would be redundand, since the absence of a "required" tag already indicates that some kind of default behaviour happens. The difference between "no default (user has to enter something himfself)" and "no default that we want to specify here" is made by having the NO_DEF token with the "repuired" tag present or absent, respectively. If we want to have different tokens for these cases, we could consider dropping the "required" tag.

@sebffischer
Copy link
Member Author

sebffischer commented Oct 17, 2023

Ah sorry, I might have misremembered some details.
So we decided to only change the rd_info.ParamSet function to print this more explicitly? (should have written this down immediately)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants