From 1184f4bed419d906a9305f649ec6d932c2b26bf9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Ma=C5=9Blanka?= Date: Wed, 30 Oct 2024 12:53:19 +0100 Subject: [PATCH] iceberg: use uppercase strings to represent data file format MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Iceberg is a bit inconsistent when defining this. Some libraries (pyiceber in particular) requires it to be upper case string. For Redpanda the case doesn't matter as we always lower case the value when parsing it. Signed-off-by: Michał Maślanka --- src/v/iceberg/manifest_entry_values.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/v/iceberg/manifest_entry_values.cc b/src/v/iceberg/manifest_entry_values.cc index 19cb4399a41c..5a5fb11d55a2 100644 --- a/src/v/iceberg/manifest_entry_values.cc +++ b/src/v/iceberg/manifest_entry_values.cc @@ -143,11 +143,11 @@ data_file_content_type content_from_int(int c) { iobuf format_to_str(data_file_format f) { switch (f) { case data_file_format::avro: - return iobuf::from("avro"); + return iobuf::from("AVRO"); case data_file_format::orc: - return iobuf::from("orc"); + return iobuf::from("ORC"); case data_file_format::parquet: - return iobuf::from("parquet"); + return iobuf::from("PARQUET"); } }