Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are we restricting just to the first static code per patient? Shouldn't we want to summarize all static codes? #76

Open
mmcdermott opened this issue Aug 11, 2024 · 3 comments
Labels
bug Something isn't working question Further information is requested

Comments

@mmcdermott
Copy link
Owner

first_code_subset = code_subset.group_by(pl.col("patient_id")).first().collect()

@Oufattole and @teyaberg , am I just misunderstanding something here?

@mmcdermott mmcdermott added bug Something isn't working question Further information is requested labels Aug 11, 2024
@mmcdermott
Copy link
Owner Author

We should add doctests to this function either way.

@mmcdermott
Copy link
Owner Author

Maybe did you mean to group by both "patient_id" and "code"?

@Oufattole
Copy link
Collaborator

Yeah that's a bug, I meant to group by both "patient_id" and "code", great catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants