Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should make our config names more package specific #86

Open
mmcdermott opened this issue Aug 29, 2024 · 1 comment
Open

We should make our config names more package specific #86

mmcdermott opened this issue Aug 29, 2024 · 1 comment

Comments

@mmcdermott
Copy link
Owner

E.g., add "_"s in front of them. This won't affect our code's interface, but if someone ever tries to import one of our provided configs as a default in hydra, this will make it harder to accidentally suffer from name collision which causes hydra to go into an infinite recursion loop.

@mmcdermott
Copy link
Owner Author

Relevant issues with more discussion: facebookresearch/hydra#1828, justin13601/ACES#122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant