Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it such that external_splits specification can point to a patient_splits.parquet file or a prior splits.json file from MEDS-extract to match the cohort. #130

Open
3 tasks
mmcdermott opened this issue Aug 8, 2024 · 0 comments
Labels
documentation Improvements or additions to documentation MEDS Formal Compatability For efforts to ensure formal compatibility with the MEDS schema MEDS-Extract priority:medium A medium priority issue. Usability / Interface

Comments

@mmcdermott
Copy link
Owner

Right now, if you point external_splits to a prior dataset's splits.json file, it will treat the shard name as part of the split. This should be fixed such that you can point to a single "splits" file and have it reload the right splits, not the shards part.

Tagging @prenc for tracking

My current thoughts as to what should change about this:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation MEDS Formal Compatability For efforts to ensure formal compatibility with the MEDS schema MEDS-Extract priority:medium A medium priority issue. Usability / Interface
Projects
None yet
Development

No branches or pull requests

1 participant